[docs] gh-101273: Expand enum documentation on limitations#101274
Closed
samypr100 wants to merge 1 commit intopython:mainfrom
Closed
[docs] gh-101273: Expand enum documentation on limitations#101274samypr100 wants to merge 1 commit intopython:mainfrom
samypr100 wants to merge 1 commit intopython:mainfrom
Conversation
samypr100
force-pushed
the
enum-docs-update
branch
from
2719ecb to
1bbd095
Compare
ethanfurman
reviewed
Jan 24, 2023
Member
ethanfurman
left a comment
ethanfurman
left a comment
There was a problem hiding this comment.
I'm not sure this needs to be in the docs; I am sure that this is not the right section for them to be in. I'll try to review the enum docs this week to see if there is a better spot for this warning.
Contributor
Author
|
@ethanfurman To expand a little on the motivation, the codebase that I originally encountered this had something close to class ElementType(StrEnum):
title = "..."
comment = "..."
author = "..."
# ...It didn't occur to me at first that the errors I was seeing in mypy (mypy was being added after the fact) were due to |
sobolevn
reviewed
Jan 24, 2023
Misc/NEWS.d/next/Documentation/2023-01-23-17-55-15.gh-issue-101273.Ae-Hed.rst
Outdated
Show resolved
Hide resolved
samypr100
force-pushed
the
enum-docs-update
branch
from
1bbd095 to
afde363
Compare
Member
|
Closing in favor of #103596. Thank you, @samypr100 for the encouragement to properly fix this behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101273